[ 
https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092458#comment-15092458
 ] 

Varun Saxena commented on YARN-4238:
------------------------------------

Sorry for coming a little late on this.

I was basically talking about insert timestamps which were maintained in ATSv1 
in addition to start time which entity carries. These insert timestamps denoted 
when an entity was first inserted into the store. If modified time had to 
denote when an entity was updated in the store, it would be somewhat related to 
this insert timestamp.
So I was wondering if we really have a usecase for keeping track of when 
records are actually put into the store.
In ATSv1, using this insert timestamp, we could then filter entities by an 
optional query parameter named {{fromTs}}. If fromTs is not null, we ignore 
entities that were inserted into the store after the given timestamp.

I however could not find this fromTs in Tez codebase(from a simple search of 
code online).

Hence, from the discussion so far it doesnt seem that we have a very strong use 
case for modified time.
Therefore, as Sangjin and Naga said, I too am +1 with removing the modified 
time.


> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-feature-YARN-2928.002.patch, YARN-4238-feature-YARN-2928.003.patch, 
> YARN-4238-feature-YARN-2928.02.patch
>
>
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to