[ 
https://issues.apache.org/jira/browse/YARN-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116438#comment-15116438
 ] 

Sangjin Lee commented on YARN-4238:
-----------------------------------

I skimmed through the patch, and it looks good for the most part. I believe 
this is a pretty straightforward change.

The only issue is that the javadoc for ApplicationTable and EntityTable 
contains the description for "modifiedTime" in the schema. Could you please 
edit the javadoc to remove them? Thanks!

> createdTime and modifiedTime is not reported while publishing entities to 
> ATSv2
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4238
>                 URL: https://issues.apache.org/jira/browse/YARN-4238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4238-YARN-2928.01.patch, 
> YARN-4238-YARN-2928.04.patch, YARN-4238-feature-YARN-2928.002.patch, 
> YARN-4238-feature-YARN-2928.003.patch, YARN-4238-feature-YARN-2928.04.patch
>
>
> While publishing entities from RM and elsewhere we are not sending created 
> time. For instance, created time in TimelineServiceV2Publisher class and for 
> other entities in other such similar classes is not updated. We can easily 
> update created time when sending application created event. Likewise for 
> modification time on every write.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to