[
https://issues.apache.org/jira/browse/YARN-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110358#comment-15110358
]
Rohith Sharma K S commented on YARN-4617:
-----------------------------------------
Updated the patch with following changes
# Created separate ordering policy for pending apps and it is constant
nevertheless of any ordering policy configured.
# {{LeafQueue#pendingOrderingPolicy}} loads always
FifoOrderingPolicyForPendingApps
# Clean up {{LeafQueue#pendingOPForRecoveredApps}} since recovery comparator
introduced.
# Newly added test {{TestFifoOrderingPolicyForPendingApps#testIterators}}
verifies the order of applications in combine with recovering and
non-recovering applications with priority configured.
> LeafQueue#pendingOrderingPolicy should always use fixed ordering policy
> instead of using same as active applications ordering policy
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4617
> URL: https://issues.apache.org/jira/browse/YARN-4617
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Affects Versions: 2.8.0
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4617.patch
>
>
> In discussion with [~leftnoteasy] in the JIRA
> [comment|https://issues.apache.org/jira/browse/YARN-4479?focusedCommentId=15108236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15108236]
> pointed out that {{LeafQueue#pendingOrderingPolicy}} should NOT be assumed
> to be same as active applications ordering policy. It causes an issue when
> using fair ordering policy.
> Expectations of this JIRA should include
> # Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
> # Comparator of new ordering policy should use
> RecoveryComparator,PriorityComparator and Fifocomparator in order
> respectively.
> # Clean up {{LeafQueue#pendingOPForRecoveredApps}} which is no more required
> once new fixed ordering policy is created pending applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
