[
https://issues.apache.org/jira/browse/YARN-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111980#comment-15111980
]
Rohith Sharma K S commented on YARN-4617:
-----------------------------------------
thanks [~sunilg] for the comments, I will update the patch fixing the comments
bq. I think we can return unmodifiable set here. Because we already say it
read-only.
Right, we have separate similar JIRA YARN-4547 to track active-applications.
May be I can club both together in this patch only or-else I can do it in
YARN-4547.
bq. isAttemptRecovering -->isRecovering , is this change needed?. May be
isAttemptRecovering is more informative
Since SchedulableEntity is generic interface, all the API's in the interface
made generic. And SchedulableEntity can be for application/application-attempt.
So I changed the API name {{isAttemptRecovering -->isRecovering}} generic.
bq. fsApp looks more readable.
make sense, I reverted the changes made by YARN-4479 for leaf-queue, so earlier
code has been retained. I will make a change in next patch.
> LeafQueue#pendingOrderingPolicy should always use fixed ordering policy
> instead of using same as active applications ordering policy
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4617
> URL: https://issues.apache.org/jira/browse/YARN-4617
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Affects Versions: 2.8.0
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4617.patch
>
>
> In discussion with [~leftnoteasy] in the JIRA
> [comment|https://issues.apache.org/jira/browse/YARN-4479?focusedCommentId=15108236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15108236]
> pointed out that {{LeafQueue#pendingOrderingPolicy}} should NOT be assumed
> to be same as active applications ordering policy. It causes an issue when
> using fair ordering policy.
> Expectations of this JIRA should include
> # Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
> # Comparator of new ordering policy should use
> RecoveryComparator,PriorityComparator and Fifocomparator in order
> respectively.
> # Clean up {{LeafQueue#pendingOPForRecoveredApps}} which is no more required
> once new fixed ordering policy is created pending applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
