[
https://issues.apache.org/jira/browse/YARN-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110926#comment-15110926
]
Sunil G commented on YARN-4617:
-------------------------------
Thanks [~rohithsharma] for the patch.
Overall looks good.
Minor nits:
1. Not introduced by this patch
{noformat}
* Obtain (read-only) collection of pending applications.
*/
public Collection<FiCaSchedulerApp> getPendingApplications() {
{noformat}
I think we can return unmodifiable set here. Because we already say it
read-only.
2. {{isAttemptRecovering}} -->{{isRecovering}} , is this change needed?. May be
isAttemptRecovering is more informative.
3.
In {{activateApplications}}
{code}
- fsApp.remove();
+ i.remove();
{code}
fsApp looks more readable.
4. Some more information about this comparator as java doc in
{{FifoOrderingPolicyForPendingApps}} class may be helpful.
Similarly {{RecoveryComparator}} note also can be informative.
Also as I see YARN-4479 has added more cases for pending apps. hence we dont
need more tests, correct.
> LeafQueue#pendingOrderingPolicy should always use fixed ordering policy
> instead of using same as active applications ordering policy
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4617
> URL: https://issues.apache.org/jira/browse/YARN-4617
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Affects Versions: 2.8.0
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4617.patch
>
>
> In discussion with [~leftnoteasy] in the JIRA
> [comment|https://issues.apache.org/jira/browse/YARN-4479?focusedCommentId=15108236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15108236]
> pointed out that {{LeafQueue#pendingOrderingPolicy}} should NOT be assumed
> to be same as active applications ordering policy. It causes an issue when
> using fair ordering policy.
> Expectations of this JIRA should include
> # Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
> # Comparator of new ordering policy should use
> RecoveryComparator,PriorityComparator and Fifocomparator in order
> respectively.
> # Clean up {{LeafQueue#pendingOPForRecoveredApps}} which is no more required
> once new fixed ordering policy is created pending applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
