[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228684#comment-15228684
]
Sunil G commented on YARN-4855:
-------------------------------
bq.This would be a incompatible change
Yes. I agree with [~Naganarasimha Garla] here. This can be an incompatible
behavior compared to older version. Suddenly we may get some exception which
were not thrown earlier.
{{yarn rmadmin -replaceLabelsOnNode -checkNode "node1=label1"}} seems to me
like a workaround rather than a clean fix. And it may be difficult to
understand what is meant by {{-checkNode}}. So I would like to get some more
thoughts on original point with few suggestions.
- Could we support this validation in {{replaceLabelsOnNode}} and document it
cleanly about the new validation. OR
- Can we skip such nodes which are not existing, but log it clearly (may be
audit log too).
I think in this earlier stages, it may be better. But its very much debatable.
Thoughts?
> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
> Key: YARN-4855
> URL: https://issues.apache.org/jira/browse/YARN-4855
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Tao Jie
> Priority: Minor
> Attachments: YARN-4855.001.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode "node1=label1"*, it would be
> denied if node does not exist.
> When we use *yarn rmadmin -replaceLabelsOnNode -force "node1=label1"* would
> add nodelabels no matter whether node exists
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
