[ 
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229408#comment-15229408
 ] 

Wangda Tan commented on YARN-4855:
----------------------------------

Thanks [~Tao Jie] and discussions from [~Naganarasimha], [~sunilg].

[Comment|https://issues.apache.org/jira/browse/YARN-4855?focusedCommentId=15227603&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15227603]
 looks doable and backward compatible. However, \-checkNode seems very 
confusing. How about renaming it to "--fail-on-unkown-nodes", which is longer 
but clearer.

Thoughts?

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not 
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode "node1=label1"*, it would be 
> denied if node does not exist.
> When we use *yarn rmadmin -replaceLabelsOnNode -force "node1=label1"* would 
> add nodelabels no matter whether node exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to