[ 
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228937#comment-15228937
 ] 

Naganarasimha G R commented on YARN-4855:
-----------------------------------------

Thanks  [~sunilg] for sharing your views, as i mentioned earlier IIUC the 
intent of not validating the existance of the node is to just make admin life 
easier so that in certain cases he need not worry whether the node is 
temporarily down and he can just apply the label mappings. so approaches you 
mentioned overrides this behavior. 

But I can also understand [~Tao Jie]'s concern that if the node (host ip or 
port) is wrongly configured better to warn before hand than erroneously 
configure the cluster.
So we have pro's and cons with the existing approach.

So i am ok with [~Tao Jie]'s approach but with better option name (-verifyNode 
?), also one more aspect is does it require a protocol change can we do it in 
the client side ? 

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not 
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode "node1=label1"*, it would be 
> denied if node does not exist.
> When we use *yarn rmadmin -replaceLabelsOnNode -force "node1=label1"* would 
> add nodelabels no matter whether node exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to