[
https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317214#comment-15317214
]
Carlo Curino commented on YARN-5124:
------------------------------------
Few issues, mostly minor:
# Please add javadoc for {{AMRMClientSync.getMatchingRequest()}} or is this an
override?
# Can we wrap this datastructure in some object? {{Map<Priority, Map<String,
Map<ExecutionType, TreeMap<Resource, ResourceRequestInfo>>>>}} it is starting
to get a bit too complicated to follow, and we might eventually want to change
representations.
# Do you need the new constructor {{AMRMClientImpl(ApplicationMasterProtocol
protocol)}}? Can't you use mockito for the conf in tests and pass the
ApplicationMasterProtocol that way?
# The ordering of where ExecutionType goes is not consistent, in
ResourceRequest is at the end, while in most other places is earlier. Strong
typing make this not a big deal, just looks cleaner if consistent.
# {{AMRMClient.getMatchingRequests()}} in Javadoc you refer to the "above"
method for explanation. I think is easier for readers if you copy the content
of javadoc, in IDEs pop-ups you don't see "the above" method necessarily.
(I didn't check tests yet)
> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
> Key: YARN-5124
> URL: https://issues.apache.org/jira/browse/YARN-5124
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5124.001.patch, YARN-5124.002.patch,
> YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch,
> YARN-5124.006.patch, YARN-5124.008.patch, YARN-5124.009.patch,
> YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}}
> in the AMRMClient, but it is not being set in the actual {{ResourceRequest}}
> that is sent to the RM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
