[
https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316114#comment-15316114
]
Karthik Kambatla commented on YARN-5124:
----------------------------------------
[~asuresh] - excuse the delay in getting around to this.
Comments on the patch:
# The new AMRMClient#createAMRMClient method, are we really sure we want to
expose this as a Public method. What is the user supposed to use it with? I am
assuming this was intended to be a test-only method? Let us add a comment that
this method could be private otherwise.
# Can we mark the new AMRMClientImpl @VisibleForTesting and add a comment that
this method can be private otherwise.
# AMRMClient seems to add an abstract method. Since it is a Public-Stable
class, we should have a default implementation. Throw
UnsupportedOperationException?
# Add @Override AMRMClientAsyncImpl#getMatchingRequests?
# AMRMClient implementation: I must be missing something here. Don't we need to
track ExecutionTypeRequest and not just ExecutionType, say in
remoteRequestsTable?
# Haven't paid close attention to the tests. Will do so once these comments are
addressed.
> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
> Key: YARN-5124
> URL: https://issues.apache.org/jira/browse/YARN-5124
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5124.001.patch, YARN-5124.002.patch,
> YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch,
> YARN-5124.006.patch, YARN-5124.008.patch,
> YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}}
> in the AMRMClient, but it is not being set in the actual {{ResourceRequest}}
> that is sent to the RM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
