[
https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388597#comment-15388597
]
Wangda Tan commented on YARN-5392:
----------------------------------
Thanks for updating, [~asuresh]:
Some more comments:
1) Many places called SchedulerKey.create, I think we can avoid many of them by
doing following:
- add getSchedulerKey at SchedContainerChangeRequest
- store SchedulerKey reference in RMContainerImpl
- FifoSchedulerSelector can use RMContainer#get...SchedulerKey instead of
extraFrom container
- Actually SchedulerKey.extractFrom can be removed since we already have the
method in RMContainer
- getAllocatedPriority should return priority of {{container}}
2) The name "SchedulerKey" is a little too general to me, it is added
particularily for resource requests inside one app. How about calling it
SchedulerRequestKey?
3) Several "TODO" comments can be removed, it should be done independently in
YARN-4888, not directly related to this change
4) Not directly related to the patch: {{getLocalityWaitFactor}} and
{{getTotalPendingRequests}} can be removed
> Replace use of Priority in the Scheduling infrastructure with an opaque
> ShedulerKey
> -----------------------------------------------------------------------------------
>
> Key: YARN-5392
> URL: https://issues.apache.org/jira/browse/YARN-5392
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5392.001.patch, YARN-5392.002.patch,
> YARN-5392.003.patch, YARN-5392.004.patch, YARN-5392.005.patch,
> YARN-5392.006.patch
>
>
> Based on discussions in YARN-4888, this jira proposes to replace the use of
> {{Priority}} in the Scheduler infrastructure (Scheduler, Queues, SchedulerApp
> / Node etc.) with a more opaque and extensible {{SchedulerKey}}.
> Note: Even though {{SchedulerKey}} will be used by the internal scheduling
> infrastructure, It will not be exposed to the Client or the AM. The
> SchdulerKey is meant to be an internal construct that is derived from
> attributes of the ResourceRequest / ApplicationSubmissionContext / Scheduler
> Configuration etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
