[
https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391285#comment-15391285
]
Karthik Kambatla commented on YARN-5392:
----------------------------------------
Patch looks mostly good. Have mostly minor comments:
# SchedulerRequestKey:
## Thinking out loud. The name is very implementation specific. Is there a name
that would be more descriptive of what all it captures?
## Thinking out loud again. Should the locality information (resourceName) also
be part of SchedulerRequestKey. Why or why not? May be file a follow-up JIRA to
well follow-up. :)
# Application
## Since this code is going to be Java7+, omit types in the generics on
creating maps?
## The new method addResourceRequestSpec seems to be for testing. Let us add
@VisibleForTesting and @Deprecated, and add a comment that it shouldn't be used
by any other code. May be file a follow-up newbie JIRA to update the tests and
get rid of this method?
# FairSchedulerTestBase change is spurious. Belongs in the other patch?
# FicaSchedulerApp: Spurious blank lines in imports
# RMContainer and Impl: In principle, I agree with Wangda about limiting the
changes only to the scheduler. Would like to understand why the RMContainer
needs to track SchedulerKey. For instance, do we foresee the AllocateRequestID
to show in RMContainer?
# FifoScheduler: Spurious blank lines in imports
# FSAppAttempt:
## Spurious blank lines in imports
## Leave out types when instantiating allowedLocalityLevel
# FSSchedulerNode: Spurious blank lines
# MockAM change is spurious?
# SchedulerApplicationAttempt: Leave out types when defining
lastSchedulerContainer
> Replace use of Priority in the Scheduling infrastructure with an opaque
> ShedulerKey
> -----------------------------------------------------------------------------------
>
> Key: YARN-5392
> URL: https://issues.apache.org/jira/browse/YARN-5392
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5392.001.patch, YARN-5392.002.patch,
> YARN-5392.003.patch, YARN-5392.004.patch, YARN-5392.005.patch,
> YARN-5392.006.patch, YARN-5392.007.patch, YARN-5392.008.patch
>
>
> Based on discussions in YARN-4888, this jira proposes to replace the use of
> {{Priority}} in the Scheduler infrastructure (Scheduler, Queues, SchedulerApp
> / Node etc.) with a more opaque and extensible {{SchedulerKey}}.
> Note: Even though {{SchedulerKey}} will be used by the internal scheduling
> infrastructure, It will not be exposed to the Client or the AM. The
> SchdulerKey is meant to be an internal construct that is derived from
> attributes of the ResourceRequest / ApplicationSubmissionContext / Scheduler
> Configuration etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
