[
https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391356#comment-15391356
]
Arun Suresh commented on YARN-5392:
-----------------------------------
Thanks for taking a look [~kasha],
bq. The name is very implementation specific. Is there a name that would be
more descriptive of what all it captures ?
Given that this is a primary key for the *AppSchedulingInfo*, Does
*AppSchedulingKey* make sense ? or maybe *ResourceSchedulingKey* to signify, it
is only for App ResourceRequests ?
bq. Should the locality information (resourceName) also be part of
SchedulerRequestKey. ? Why or why not? May be file a follow-up JIRA to well
follow-up.
My intuition is that it should not, given that if it is, a lot of the
DelayScheduling logic would be impacted. In any case, like you suggested, lets
revisit this when required.
bq. RMContainer and Impl ...
I too agree that the change to be limited to the Scheduler hierarchy, but
unfortunately, unlike RMApp, RMNode and Queue, we do not have a Scheduler
specific hierarchy. I had initially proposed having static methods like the
*extractFrom(RMContainer)* static method that can return a key given the
RMContainer.. Thoughts ?
I agree with the rest of your comments.. Shall update patch with the changes
based on your thoughts on the above.
> Replace use of Priority in the Scheduling infrastructure with an opaque
> ShedulerKey
> -----------------------------------------------------------------------------------
>
> Key: YARN-5392
> URL: https://issues.apache.org/jira/browse/YARN-5392
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5392.001.patch, YARN-5392.002.patch,
> YARN-5392.003.patch, YARN-5392.004.patch, YARN-5392.005.patch,
> YARN-5392.006.patch, YARN-5392.007.patch, YARN-5392.008.patch
>
>
> Based on discussions in YARN-4888, this jira proposes to replace the use of
> {{Priority}} in the Scheduler infrastructure (Scheduler, Queues, SchedulerApp
> / Node etc.) with a more opaque and extensible {{SchedulerKey}}.
> Note: Even though {{SchedulerKey}} will be used by the internal scheduling
> infrastructure, It will not be exposed to the Client or the AM. The
> SchdulerKey is meant to be an internal construct that is derived from
> attributes of the ResourceRequest / ApplicationSubmissionContext / Scheduler
> Configuration etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
