[
https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402675#comment-15402675
]
Jason Lowe commented on YARN-5382:
----------------------------------
Thanks for updating the patch!
Nit: RMAppKillByClientLogEvent should just be RMAppKillByClientEvent. The
event represents an application kill request coming from a client. The logging
is an implementation detail of how the event will be processed. Event classes
should be named after what event they represent rather than how the event will
be processed, otherwise when the processing details change then the event name
becomes misleading/confusing.
The createSuccessLog version without an IP parameter should just call the
createSuccessLog version with the parameter. Instead of passing null, it can
call getRemoteIp. Then createSuccessLog with an IP parameter can be simplified
to just logging an IP key if the ip is not null. That makes it consistent with
how it treats the other, possibly-null parameters as well.
Otherwise patch looks good. Could you also provide patches for 2.8 and 2.7?
> RM does not audit log kill request for active applications
> ----------------------------------------------------------
>
> Key: YARN-5382
> URL: https://issues.apache.org/jira/browse/YARN-5382
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.2
> Reporter: Jason Lowe
> Assignee: Vrushali C
> Attachments: YARN-5382-branch-2.7.01.patch,
> YARN-5382-branch-2.7.02.patch, YARN-5382-branch-2.7.03.patch,
> YARN-5382-branch-2.7.04.patch, YARN-5382-branch-2.7.05.patch,
> YARN-5382.06.patch, YARN-5382.07.patch, YARN-5382.08.patch
>
>
> ClientRMService will audit a kill request but only if it either fails to
> issue the kill or if the kill is sent to an already finished application. It
> does not create a log entry when the application is active which is arguably
> the most important case to audit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
