[ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405321#comment-15405321 ]
Jian He commented on YARN-5382: ------------------------------- bq. I see only one audit log message when I ran a sleep job and killed it on pseudo-distributed setup on my laptop I checked the code more, that's because AppKilledTransition will not get the RMAppKillByClientEvent any more if there exists an attempt - AppKilledTransition is processing the event sent from RMAppAttempt if there exists the attempt. Anyway, this actually makes things better, because we won't have two audit logs. - This code is exactly the same in two places, would you make a common method for it ? {code} if (event instanceof RMAppKillByClientEvent) { RMAppKillByClientEvent killEvent = (RMAppKillByClientEvent) event; UserGroupInformation callerUGI = killEvent.getCallerUGI(); String userName = null; if (callerUGI != null) { userName = callerUGI.getShortUserName(); } InetAddress remoteIP = killEvent.getIp(); RMAuditLogger.logSuccess(userName, AuditConstants.KILL_APP_REQUEST, "RMAppImpl", event.getApplicationId(), remoteIP); } {code} - Isn't "greater than" the correct wording ? {code} - Assert.assertTrue("application start time is not greater than 0", + Assert.assertTrue("application start time is not greater then 0", {code} - several parameters are not used in this method testSuccessLogFormatHelperWithIP, remove them ? - nit highlighted by IDE: "returns the {@link CallerUGI}" the CallerUGI is actually not a link. > RM does not audit log kill request for active applications > ---------------------------------------------------------- > > Key: YARN-5382 > URL: https://issues.apache.org/jira/browse/YARN-5382 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.7.2 > Reporter: Jason Lowe > Assignee: Vrushali C > Attachments: YARN-5382-branch-2.7.01.patch, > YARN-5382-branch-2.7.02.patch, YARN-5382-branch-2.7.03.patch, > YARN-5382-branch-2.7.04.patch, YARN-5382-branch-2.7.05.patch, > YARN-5382-branch-2.7.09.patch, YARN-5382-branch-2.7.10.patch, > YARN-5382.06.patch, YARN-5382.07.patch, YARN-5382.08.patch, > YARN-5382.09.patch, YARN-5382.10.patch > > > ClientRMService will audit a kill request but only if it either fails to > issue the kill or if the kill is sent to an already finished application. It > does not create a log entry when the application is active which is arguably > the most important case to audit. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org