[
https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404694#comment-15404694
]
Jason Lowe commented on YARN-5382:
----------------------------------
If we keep the kill success logging in both a transition and in ClientRMService
then we'll get two audit logs instead of one.
I also don't think it's as simple as removing the one from
KillAttemptTransition since then we won't get a log if the RM fails over just
as it saved the killed state of an app but before it executed the
AppKilledTransition. IMHO we need to log it once, before we enter the
FINAL_SAVING state to record the killed transition. Then we might get two
audit logs during a failover (one on each RM instance) but that's far
preferable to none.
> RM does not audit log kill request for active applications
> ----------------------------------------------------------
>
> Key: YARN-5382
> URL: https://issues.apache.org/jira/browse/YARN-5382
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.2
> Reporter: Jason Lowe
> Assignee: Vrushali C
> Attachments: YARN-5382-branch-2.7.01.patch,
> YARN-5382-branch-2.7.02.patch, YARN-5382-branch-2.7.03.patch,
> YARN-5382-branch-2.7.04.patch, YARN-5382-branch-2.7.05.patch,
> YARN-5382-branch-2.7.09.patch, YARN-5382.06.patch, YARN-5382.07.patch,
> YARN-5382.08.patch, YARN-5382.09.patch
>
>
> ClientRMService will audit a kill request but only if it either fails to
> issue the kill or if the kill is sent to an already finished application. It
> does not create a log entry when the application is active which is arguably
> the most important case to audit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
