[
https://issues.apache.org/jira/browse/YARN-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440046#comment-15440046
]
Subru Krishnan commented on YARN-5221:
--------------------------------------
I looked at the patch. +1 from my side (pending Yetus as the reports seem to
have expired), just a few minor comments:
* I think it is better to retain the old constructor of
{{ContainerTokenIdentifier}} and call the new one with implicit 0 version to
avoid changes to *MRApp* and possibly other applications. This will also avoid
changing existing tests that don't use container versioning.
* Nit: will be good to call out in the javadocs of {{Container}} that
versions are incremented as a side effect of update requests.
* Is it possible to use enum in {{UpdateContainerRequest}} to strictly
enforce only one aspect changes?
* Nit: You can use @link instead of <code> in javadocs of
{{UpdateContainerRequest}} as there's is direct compile dependency.
A thought - can we defer splitting increase/decreaseRequests to the actual
scheduler as now we will have to propagate every new changeable container
attribute?
> Expose UpdateResourceRequest API to allow AM to request for change in
> container properties
> ------------------------------------------------------------------------------------------
>
> Key: YARN-5221
> URL: https://issues.apache.org/jira/browse/YARN-5221
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5221.001.patch, YARN-5221.002.patch,
> YARN-5221.003.patch, YARN-5221.004.patch, YARN-5221.005.patch,
> YARN-5221.006.patch, YARN-5221.007.patch, YARN-5221.008.patch
>
>
> YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease
> of Container Resources after initial allocation.
> YARN-5085 proposes to allow an AM to request for a change of Container
> ExecutionType.
> This JIRA proposes to unify both of the above into an Update Container API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
