[
https://issues.apache.org/jira/browse/YARN-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447168#comment-15447168
]
Wangda Tan commented on YARN-5221:
----------------------------------
[~asuresh],
Sorry for my late comment, some minor issues for annotations:
UpdatedContainer:
- Mark the whole class to Public/Unstable?
ContainerUpdateType:
- Add annotation to Public/unstable?
- INCREASE_CAPABILITY or INCREASE_RESOURCE?
AMRMClientAsync.AbstractCallbackHandler#onContainersResourceChanged:
- Do you think we should remove this method and add a onContainersUpdated?
- At least we should make this new method to Public/unstable since we could
break it in the future.
o.a.h.y.api.Container:
- serVersion should be private/unstable, and should throw
UnsupportedOperationException
- Not caused by this patch, setAllocationRequestId should be private/unstable.
NMLeveldbStateStoreService:
- Not sure if the change will cause stored data compability issues while doing
rolling upgrade. (New NM read old data)
RMServerUtils.java:
- Lots of unnecessary formatting changes, is it possible to revert these
changes?
> Expose UpdateResourceRequest API to allow AM to request for change in
> container properties
> ------------------------------------------------------------------------------------------
>
> Key: YARN-5221
> URL: https://issues.apache.org/jira/browse/YARN-5221
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5221.001.patch, YARN-5221.002.patch,
> YARN-5221.003.patch, YARN-5221.004.patch, YARN-5221.005.patch,
> YARN-5221.006.patch, YARN-5221.007.patch, YARN-5221.008.patch,
> YARN-5221.009.patch, YARN-5221.010.patch
>
>
> YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease
> of Container Resources after initial allocation.
> YARN-5085 proposes to allow an AM to request for a change of Container
> ExecutionType.
> This JIRA proposes to unify both of the above into an Update Container API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
