[ 
https://issues.apache.org/jira/browse/YARN-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446874#comment-15446874
 ] 

Subru Krishnan commented on YARN-5221:
--------------------------------------

Thanks [~asuresh] for addressing my feedback. 

I feel few of the checkstyle warnings can be fixed.

When I was making a final pass on the patch, I realized that in 
{{RMServerUtils::validateAndSplitUpdateResourceRequests}}, we are only 
validating update requests within the current _AllocateRequest_ but we should 
be checking against global outstanding update asks as the allocate protocol is 
asynchronous. I am fine with addressing this in a separate JIRA along with the 
refactoring work based on your comment 
[above|https://issues.apache.org/jira/browse/YARN-5221?focusedCommentId=15442729].

> Expose UpdateResourceRequest API to allow AM to request for change in 
> container properties
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-5221
>                 URL: https://issues.apache.org/jira/browse/YARN-5221
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5221.001.patch, YARN-5221.002.patch, 
> YARN-5221.003.patch, YARN-5221.004.patch, YARN-5221.005.patch, 
> YARN-5221.006.patch, YARN-5221.007.patch, YARN-5221.008.patch, 
> YARN-5221.009.patch, YARN-5221.010.patch
>
>
> YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease 
> of Container Resources after initial allocation.
> YARN-5085 proposes to allow an AM to request for a change of Container 
> ExecutionType.
> This JIRA proposes to unify both of the above into an Update Container API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to