[
https://issues.apache.org/jira/browse/YARN-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466519#comment-15466519
]
Jian He commented on YARN-4205:
-------------------------------
Thanks Rohith, looks good overall, few comments:
- can you clarify the definition of lifetime in the API, and also mention the
unit of the time in the getter API
- RMAppRecoveredTransition: this will cause a lot of loggings for active apps
on RM recovery, remove it as it is already logged in the normal run path ? or
move to debug level ?
{code}
LOG.info("Application " + app.applicationId
 + " is registered with
Application lifetime monitor after recovery. "
 + "The lifetime configured
is " + applicationLifetime + " seconds");
{code}
- use getLong ?
{code}
int monitorInterval = conf.getInt(
YarnConfiguration.RM_APPLICATION_LIFETIME_MONITOR_INTERVAL_MS,
YarnConfiguration.DEFAULT_RM_APPLICATION_LIFETIME_MONITOR_INTERVAL_MS);
{code}
> Add a service for monitoring application life time out
> ------------------------------------------------------
>
> Key: YARN-4205
> URL: https://issues.apache.org/jira/browse/YARN-4205
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Reporter: nijel
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4205.patch, 0002-YARN-4205.patch,
> YARN-4205_01.patch, YARN-4205_02.patch, YARN-4205_03.patch
>
>
> This JIRA intend to provide a lifetime monitor service.
> The service will monitor the applications where the life time is configured.
> If the application is running beyond the lifetime, it will be killed.
> The lifetime will be considered from the submit time.
> The thread monitoring interval is configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
