Rohith Sharma K S commented on YARN-4205:

Thanks [~gsaha] for review. 

bq.   For the second argument, do we mean timeout or submitTime?
Its neither timeout nor submitTime.  It is basically startTime for monitoring. 
May be it can be change to monitorStartTime?

bq. Hardcoded ports cause unit test parallelization challenges. Is it possible 
to request a free port from the OS?
This is fine, MockNM framework does not bind to any port. So, random port issue 
does not occur. 

I will update patch fixing rest of the comments. 

> Add a service for monitoring application life time out
> ------------------------------------------------------
>                 Key: YARN-4205
>                 URL: https://issues.apache.org/jira/browse/YARN-4205
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: nijel
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4205.patch, 0002-YARN-4205.patch, 
> 0003-YARN-4205.patch, 0004-YARN-4205.patch, YARN-4205_01.patch, 
> YARN-4205_02.patch, YARN-4205_03.patch
> This JIRA intend to provide a lifetime monitor service. 
> The service will monitor the applications where the life time is configured. 
> If the application is running beyond the lifetime, it will be killed. 
> The lifetime will be considered from the submit time.
> The thread monitoring interval is configurable.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to