[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483269#comment-15483269
]
Sunil G commented on YARN-4855:
-------------------------------
HI [~Tao Jie] and [~Naganarasimha Garla]
Thanks for the work on this item. I have doubts on the patch.
- Thinking out node, {{replaceLabelsOnNodes}} seems a little complex for me.
Could we add a server side API to check whether set of nodes are registered or
not? {{ConcurrentMap<NodeId, RMNode> getRMNodes()}} is available at server
side. So it will be faster and better approach.
- If we are sticking with client side impl, then we could try make use of
{{NodeId#compareTo}} instead of {{isNodeSame}}
> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
> Key: YARN-4855
> URL: https://issues.apache.org/jira/browse/YARN-4855
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Tao Jie
> Assignee: Tao Jie
> Priority: Minor
> Attachments: YARN-4855.001.patch, YARN-4855.002.patch,
> YARN-4855.003.patch, YARN-4855.004.patch, YARN-4855.005.patch,
> YARN-4855.006.patch, YARN-4855.007.patch, YARN-4855.008.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes
> "node1=label1"* , it would be denied if node is unknown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
