[ 
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498235#comment-15498235
 ] 

Naganarasimha G R commented on YARN-4855:
-----------------------------------------

Some how missed to comment on this ...
Though i was in sync with [~Tao Jie]'s view in his earlier comment, on second 
thoughts not sure whether performance would be good in a large cluster where in 
we need to fetch and validate in client side for about 4000 nodes to validate 
few nodes being modified. So i think we can try to modify the protocol 
{{"yarn_server_resourcemanager_service_protos.proto#ReplaceLabelsOnNodeRequestProto"}}
 to add a option boolean flag to validate the existence of the node and we can 
move the logic to server side...
Thoughts?

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch, YARN-4855.002.patch, 
> YARN-4855.003.patch, YARN-4855.004.patch, YARN-4855.005.patch, 
> YARN-4855.006.patch, YARN-4855.007.patch, YARN-4855.008.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not 
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes 
> "node1=label1"* , it would be denied if node is unknown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to