Wangda Tan commented on YARN-4945:

[~sunilg], took a quick look at the patch, overall approach looks good.

For the TODO items, I think reservation logic support can be moved to a 
separate ticket, for apps running inside the same queue, it is more likely that 
resources are more homogeneous. For the other two TODOs, it's better to be 
addressed in the same patch.

And one minor comment:
- Definition and initialization of IntraQueuePreemptionPolicy is in the 
IntraQueueCandidatesSelector now, but I think it might be better to move them 
to IntraQueuePreemptableResourceCalculator. And I think we might not need the 
userLimitBasedPolicy, it could be a part of the existing 

I will include more detailed reviews for the final patch :).


> [Umbrella] Capacity Scheduler Preemption Within a queue
> -------------------------------------------------------
>                 Key: YARN-4945
>                 URL: https://issues.apache.org/jira/browse/YARN-4945
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>         Attachments: Intra-Queue Preemption Use Cases.pdf, 
> IntraQueuepreemption-CapacityScheduler (Design).pdf, YARN-2009-wip.2.patch, 
> YARN-2009-wip.patch, YARN-2009-wip.v3.patch, YARN-2009.v0.patch, 
> YARN-2009.v1.patch
> This is umbrella ticket to track efforts of preemption within a queue to 
> support features like:
> YARN-2009. YARN-2113. YARN-4781.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to