[
https://issues.apache.org/jira/browse/YARN-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493893#comment-15493893
]
Eric Payne commented on YARN-4945:
----------------------------------
Thanks again, [~sunilg]. I will look closely at the patch, but one thing I
wanted to bring out before too much time passes is that some of the IntraQueue
classes seem priority-centric and do not lend themselves to adding multiple
intra-queue policies.
- The constructor for {{IntraQueueCandidatesSelector}} passes
{{priorityBasedPolicy}} as a parameter directly to the constructor for
{{IntraQueuePreemptableResourceCalculator}}
- {{IntraQueueCandidatesSelector#selectCandidates}} passes
{{priorityBasedPolicy}} as a parameter directly to
{{CapacitySchedulerPreemptionUtils.getResToObtainByPartitionForApps}}.
I think that the objects that implement the {{IntraQueuePreemptionPolicy}}
interface should be in in a {{List<IntraQueuePreemptionPolicy>}}, and then
{{IntraQueueCandidatesSelector#selectCandidates}} should loop over the list to
process the different policies.
----
Please change the name of variables in classes that need to be independent of
the specific intra-queue policy:
- {{CapacitySchedulerPreemptionUtils#getResToObtainByPartitionForApps}} has a
parameter named {{priorityBasedPolicy}}, but this should be generic, like
{{intraQueuePolicy}}
- {{IntraQueuePreemptableResourceCalculator}} also has a variable named
{{priorityBasedPolicy}}, which I think should be more generic.
-
{{CapacitySchedulerConfiguration#SELECT_CANDIDATES_FOR_INTRAQUEUE_PREEMPTION}}:
since the value for this property is the switch to turn on intra-queue
preemption, the name should be something more generic. Currently, it is
{{yarn.resourcemanager.monitor.capacity.preemption.select_based_on_priority_of_applications}},
but it should be something like {{enable_intra_queue_preemption}}.
> [Umbrella] Capacity Scheduler Preemption Within a queue
> -------------------------------------------------------
>
> Key: YARN-4945
> URL: https://issues.apache.org/jira/browse/YARN-4945
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Wangda Tan
> Attachments: Intra-Queue Preemption Use Cases.pdf,
> IntraQueuepreemption-CapacityScheduler (Design).pdf, YARN-2009-wip.2.patch,
> YARN-2009-wip.patch, YARN-2009-wip.v3.patch, YARN-2009.v0.patch,
> YARN-2009.v1.patch
>
>
> This is umbrella ticket to track efforts of preemption within a queue to
> support features like:
> YARN-2009. YARN-2113. YARN-4781.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
