[ 
https://issues.apache.org/jira/browse/YARN-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494187#comment-15494187
 ] 

Wangda Tan commented on YARN-4945:
----------------------------------

[~eepayne] / [~sunilg],

For the suggestion from [~eepayne]:
bq. I think that the objects that implement the IntraQueuePreemptionPolicy 
interface should be in in a List<IntraQueuePreemptionPolicy>, and then 
IntraQueueCandidatesSelector#selectCandidates should loop over the list to 
process the different policies.

I would say it may not be necessarily to have two separate policies to consider 
priority and user-limit. In my existing rough thinking, only minor changes 
required to support FIFO + Priority + user-limit intra-queue preemption, if it 
is really required, we can refactor this part when we move to user-limit 
preemption.

The other reason is the two intra-queue preemption policy (user-limit / 
priority) can affect to each other, we cannot do priority preemption without 
considering user-limit, and vice versa. So if we can consider both with a 
reasonable code complexity, why not :)?

> [Umbrella] Capacity Scheduler Preemption Within a queue
> -------------------------------------------------------
>
>                 Key: YARN-4945
>                 URL: https://issues.apache.org/jira/browse/YARN-4945
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>         Attachments: Intra-Queue Preemption Use Cases.pdf, 
> IntraQueuepreemption-CapacityScheduler (Design).pdf, YARN-2009-wip.2.patch, 
> YARN-2009-wip.patch, YARN-2009-wip.v3.patch, YARN-2009.v0.patch, 
> YARN-2009.v1.patch, YARN-2009.v2.patch
>
>
> This is umbrella ticket to track efforts of preemption within a queue to 
> support features like:
> YARN-2009. YARN-2113. YARN-4781.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to