Rohith Sharma K S commented on YARN-5699:

bq. the name DIAGNOSTICS_INFO_INFO doesn't sound quite right; just 
make sense to me, I did not notice this. I will update this.

bq. I'm a little confused by this test; it appears that we're preparing these 
entities as before (i.e. all this info is at the event level). Is that 
intended? Don't we want to reflect the same changes in this test too? I wonder 
how this test is passing then (or what it's testing even)?
frankly, I haven not done any modification in this test classes *explicitly*. I 
did *MetricsConstants classes refactoring which resulted in changes in some of 
the test classes. I can look at these test class and if any minor modifications 
I can handle it in this patch itself, otherwise we might need to re visit whole 
test class again that could be done in separate JIRA.

And also I notice that there is no specific test cases that are validating 
individual fields for entity that are published to ATSv2 in 
TestSystemMetricsPublisherForV2.  Again it is bunch of test cases to be added 
to validate each fields. 

> Retrospect yarn entity fields which are publishing in events info fields.
> -------------------------------------------------------------------------
>                 Key: YARN-5699
>                 URL: https://issues.apache.org/jira/browse/YARN-5699
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5699.YARN-5355.patch, 0001-YARN-5699.patch, 
> 0002-YARN-5699.YARN-5355.patch, 0002-YARN-5699.patch
> Currently, all the container information are published at 2 places. Some of 
> them are at entity info(top-level) and some are  at event info. 
> For containers, some of the event info should be published at container info 
> level. For example : container exist status, container state, createdTime, 
> finished time. These are general information to container required for 
> container-report. So it is better to publish at top level info field. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to