[ 
https://issues.apache.org/jira/browse/YARN-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573656#comment-15573656
 ] 

Sangjin Lee commented on YARN-5699:
-----------------------------------

Thanks for the update patch [~rohithsharma]! I think it's almost there. A few 
comments.

(AppAttemptMetricsConstants.java)
- l.55: the name {{DIAGNOSTICS_INFO_INFO}} doesn't sound quite right; just 
{{DIAGNOSTICS_INFO}}?

(ContainerMetricsConstants.java)
- l.64: same as above

(TestApplicationHistoryManagerOnTimelineStore.java)
- I'm a little confused by this test; it appears that we're preparing these 
entities as before (i.e. all this info is at the event level). Is that 
intended? Don't we want to reflect the same changes in this test too? I wonder 
how this test is passing then (or what it's testing even)?

(NMTimelinePublisher.java)
- l.207: I suspect it might be the same, but just to be explicit, should we do 
{{toString()}}?


> Retrospect yarn entity fields which are publishing in events info fields.
> -------------------------------------------------------------------------
>
>                 Key: YARN-5699
>                 URL: https://issues.apache.org/jira/browse/YARN-5699
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5699.YARN-5355.patch, 0001-YARN-5699.patch, 
> 0002-YARN-5699.YARN-5355.patch, 0002-YARN-5699.patch
>
>
> Currently, all the container information are published at 2 places. Some of 
> them are at entity info(top-level) and some are  at event info. 
> For containers, some of the event info should be published at container info 
> level. For example : container exist status, container state, createdTime, 
> finished time. These are general information to container required for 
> container-report. So it is better to publish at top level info field. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to