Am 16.05.21 um 15:57 schrieb Will J Godfrey:
I estimate that this transformation will take me about three days full
time. No other code changes shall occur at the same time, so all of you can
take a few holidays. 😁 I hereby request agreement by /all/ developers
involved in the /Yoshimi/ project to go ahead.
I would strongly recommend building against the review branch, which was
specifically created for such a purpose (and I've just updated today). If it
fails, then it's not fatal, and comparatively easy to find what went wrong.
Indeed looks like a nicely separated cosmetic change, which certainly
helps reasoning about the code. But, as a caveat, this will lead you
right into the topic of note creation, and even tiny changes here
impact the performance. In theory it should improve performance,
but as we all know, in theory, theory and practice should converge.
Letting that aside, please excuse my boldness, I'd like to directly
ask Will: Will how do you see your situation, if three experienced
and advanced C++ programmers start to plough through the code base?
Will, you are the project lead, and we will need a project lead
in such a situation, because for sure there will be disagreements
on questions of method and style and coding philosophy, and we need
someone all can agree on to help settling such disputes.
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
