Hi Yoshimi-devs,
as a side note, compiling with Clang-12 (on Debian/testing) showed some
interesting warnings; nothing really serious as far as I can tell.
Btw, once you have a developer-setup for Yoshimi and with some knowledge
about Docker and Debian packages, it is not that expensive to run such a
compile. Probably a good idea to do that e.g. before a release.
/fishy/src/Params/LFOParams.cpp:94:35: warning: implicit conversion from 'int'
to 'float' changes value from 1073741823 to 1073741824
[-Wimplicit-const-int-float-conversion]
float freqF = float(PfreqI) / Fmul2I;
~ ^~~~~~
/fishy/src/globals.h:46:16: note: expanded from macro 'Fmul2I'
#define Fmul2I 1073741823
^~~~~~~~~~
/fishy/src/Params/LFOParams.cpp:99:34: warning: implicit conversion from 'int'
to 'float' changes value from 1073741823 to 1073741824
[-Wimplicit-const-int-float-conversion]
xml->addpar("freqI", freqF * Fmul2I);
~ ^~~~~~
/fishy/src/Params/LFOParams.cpp:117:57: warning: implicit conversion from 'int'
to 'float' changes value from 1073741823 to 1073741824
[-Wimplicit-const-int-float-conversion]
PfreqI = xml->getparreal("freq", Pfreq, 0.0, 1.0) * Fmul2I;
~ ^~~~~~
In file included from /fishy/src/Synth/ADnote.cpp:35:
/fishy/src/Synth/LFO.h:45:70: warning: implicit conversion from 'int' to 'float'
changes value from 1073741823 to 1073741824 [-Wimplicit-const-int-float-conversion]
return func::LFOfreqBPMFraction((float)lfopars->PfreqI / Fmul2I);
~ ^~~~~~
/fishy/src/Interface/InterChange.cpp:5685:38: warning: implicit conversion from
'int' to 'float' changes value from 1073741823 to 1073741824
[-Wimplicit-const-int-float-conversion]
pars->setPfreq(val * Fmul2I);
~ ^~~~~~
/fishy/src/MusicIO/JackEngine.cpp:143:13: warning: 'jack_set_session_callback'
is deprecated [-Wdeprecated-declarations]
if (jack_set_session_callback
^
/usr/include/jack/session.h:189:58: note: 'jack_set_session_callback' has been
explicitly marked deprecated here
void *arg)
JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT;
^
/usr/include/jack/weakmacros.h:80:61: note: expanded from macro
'JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT'
#define JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT __attribute__((__deprecated__))
^
/fishy/src/MusicIO/JackEngine.cpp:143:13: warning: address of function
'jack_set_session_callback' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (jack_set_session_callback
^~~~~~~~~~~~~~~~~~~~~~~~~
/fishy/src/MusicIO/JackEngine.cpp:143:13: note: prefix with the address-of
operator to silence this warning
if (jack_set_session_callback
^
&
/fishy/src/MusicIO/JackEngine.cpp:598:9: warning: 'jack_session_reply' is
deprecated [-Wdeprecated-declarations]
if (jack_session_reply(jackClient, event))
^
/usr/include/jack/session.h:205:54: note: 'jack_session_reply' has been
explicitly marked deprecated here
jack_session_event_t *event)
JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT;
^
/usr/include/jack/weakmacros.h:80:61: note: expanded from macro
'JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT'
#define JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT __attribute__((__deprecated__))
^
/fishy/src/MusicIO/JackEngine.cpp:600:5: warning: 'jack_session_event_free' is
deprecated [-Wdeprecated-declarations]
jack_session_event_free(event);
^
/usr/include/jack/session.h:217:60: note: 'jack_session_event_free' has been
explicitly marked deprecated here
void jack_session_event_free (jack_session_event_t *event)
JACK_OPTIONAL_WEAK_DEPRECATED_EXPORT;
^
In file included from /fishy/build/EnvelopeUI.cpp:3:
/fishy/build/EnvelopeUI.h:56:12: warning: private field 'oldy' is not used
[-Wunused-private-field]
int oldx,oldy;
^
/fishy/build/ConfigUI.h:396:7: warning: private field 'oldrootID' is not used
[-Wunused-private-field]
int oldrootID;
^
/fishy/build/EffUI.h:49:12: warning: private field 'oldy' is not used
[-Wunused-private-field]
int oldx,oldy;
^
In file included from /fishy/build/BankUI.cpp:3:
/fishy/build/BankUI.h:55:16: warning: private field 'synth' is not used
[-Wunused-private-field]
SynthEngine *synth;
^
/fishy/build/BankUI.h:333:7: warning: private field 'EPCvalue' is not used
[-Wunused-private-field]
int EPCvalue;
^
/fishy/build/BankUI.h:334:7: warning: private field 'BankRootvalue' is not used
[-Wunused-private-field]
int BankRootvalue;
^
/fishy/build/BankUI.h:335:7: warning: private field 'oldBank' is not used
[-Wunused-private-field]
int oldBank;
^
/fishy/build/MasterUI.h:598:8: warning: private field 'word' is not used
[-Wunused-private-field]
char word [20];
^
/fishy/build/MasterUI.h:599:9: warning: private field 'windows' is not used
[-Wunused-private-field]
FILE *windows;
^
/fishy/src/UI/WidgetPDial.h:63:9: warning: private field 'home' is not used
[-Wunused-private-field]
float home;
^
In file included from /fishy/build/MidiLearnUI.cpp:3:
/fishy/build/MidiLearnUI.h:126:8: warning: private field 'label' is not used
[-Wunused-private-field]
char label[50];
^
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
