Review: Approve
> Hmmmmmm
> seems buggy
> I try to edit anything with gedit and I get
> 
> 
> Traceback (most recent call last):
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/main.py", line 484, in _insert_event_without_error
>     return self._insert_event(event, sender)
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/main.py", line 501, in _insert_event
>     event = self.extensions.apply_pre_insert(event, sender)
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/extension.py", line 316, in apply_pre_insert
>     event = ext.pre_insert_event(event, sender)
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/extensions/datasource_registry.py", line 112, in pre_insert_event
>     self._write_to_disk()
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/extensions/datasource_registry.py", line 96, in _write_to_disk
>     data = [DataSource.get_plain(datasource) for datasource in self._registry]
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/datamodel.py", line 75, in get_plain
>     datasource[prop] = plaintype(datasource[prop])
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/datamodel.py", line 70, in <lambda>
>     lambda x: map(Event.get_plain, x): (DataSource.EventTemplates,),
>   File "/home/seif/Projects/zeitgeist/fix-691167/zeitgeist/../_zeitgeist/engin
> e/datamodel.py", line 58, in get_plain
>     popo.append([int(p) for p in ev[2]])
> ValueError: invalid literal for int() with base 10: '['

OK scratch my last comment it was due to some unclean zeitgeist stuff i had
It works fine and IMHO this is how its supposed to be.
-- 
https://code.launchpad.net/~manishsinha/zeitgeist/fix-691167/+merge/43948
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~manishsinha/zeitgeist/fix-691167 into lp:zeitgeist.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to