Hi Frank,

Thanks for reviewing my fix. Native-branded zones will disappear when Solaris Express dies (which should happen in a few builds); therefore, it isn't worthwhile to fix this problem for native-branded zones. No special script code is needed for ipkg-branded zones because IPS package variants will handle the problem.


Yes, I added the same code to s10_boot.ksh in case administrators inadvertently resurrect create_ramdisk. However, your comment raises an issue: My fix won't prevent the mkisofs(8) error message in all cases. If a zone administrator somehow reinstalls create_ramdisk (say, through an update) without rebooting the zone, then if an administrator in the global zone updates boot archives via bootadm(1M), then the global zone administrator will see the mkisofs(8) error. This isn't a problem because the error is harmless and the aforementioned scenario will rarely occur.

Thanks again for the review,
Jordan


On 12/22/09 07:06 AM, Frank Batschulat (Home) wrote:
On Tue, 22 Dec 2009 00:46:00 +0100, Jordan Vaughan <jordan.vaug...@sun.com> 
wrote:

I need someone to review my fix for

6909222 reboot of system upgraded from 128 to build 129 generated error
from an s10 zone due to boot-archive

My webrev is accessible via

http://cr.opensolaris.org/~flippedb/onnv-s10c

Jordan, looks good to me.

what about /usr/lib/brand/ipkg/p2v and perhaps /usr/lib/brand/ipkg/pkgcreatezone for the ipkg brand ?

and usr/src/lib/brand/native/zone/p2v.ksh and usr/src/lib/brand/native/zone/image_install.ksh for the native brand ?

I'd assume that in the future running an s10u9 update for an s10u8 branded
zone, could that potentially put back the ' /boot/solaris/bin/create_ramdisk' script but that'd be taken care of by the s10_boot.ksh then.

cheers
frankB



_______________________________________________
zones-discuss mailing list
zones-discuss@opensolaris.org

Reply via email to