On Tue, Jan 19, 2010 at 02:33:15PM -0700, Jerry Jelinek wrote: > On 01/19/10 14:00, Edward Pilatowicz wrote: > >>> perhaps it would make sense to add some "tokens" to the comments in > >>> brand_asm.h like: > >>> 32-BIT INTERPOSITION STACK > >>> 32-BIT LCALL/INT STACK > >>> 64-BIT INTERPOSITION STACK > >>> 64-BIT LCALL/INT STACK > >>> > >>> and then in the comments for each brand callback you could refer the > >>> reader to the appropriate tokens in brand_asm.h. > >> > >>I added this. > >> > > > >could you add references to these tokens to lx_brand_asm.s as well? > > Ed, > > Will do, sorry for not adding this yesterday. Do you want to re-review it > again after that comment change? >
not really. ed _______________________________________________ zones-discuss mailing list zones-discuss@opensolaris.org
