Patrick Hunt commented on ZOOKEEPER-640:

Great to see this being packaged for Debian! Shouldn't be a problem. A few 
questions though:

1) contrib include/exclude seems fine to me, good idea

2) for the "additional.lib.dir" :

a) you want this changed in build.xml at the toplevel and also for the 
contribs, right? Same variable name
used in both ok?

b) do you really want a dir or a path string instead, ie additional.lib.dir or 
additional.libs.path (where libs.path is a list of directories/jars)

libs.path would give you more control (you would specify/order the jars 
explicitly vs just *.jar") This might be important
for example if you have multiple jars with same capability but diff version... 
it would require you to specify the
list of jars though.

> make build.xml more configurable to ease packaging for linux distros
> --------------------------------------------------------------------
>                 Key: ZOOKEEPER-640
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.2.1, 3.2.2
>            Reporter: Thomas Koch
>             Fix For: 3.3.0
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem 
> excluding contrib/rest from the build without patching the upstream tarball. 
> Could you please add some properties to your build.xml that allow me to 
> (de)select contribs? In the example below I can easily override the 
> properties:
> <project name="zookeepercontrib">
>   <property name="contribfilesetincludes" value="*/build.xml" />
>   <property name="contribfilesetexcludes" value="" />
>   <fileset id="contribfileset" 
>            dir="." 
>            includes="${contribfilesetincludes}"
>            excludes="${contribfilesetexcludes}"
>            />
>   <target name="compile">
>     <subant target="jar">
>      <fileset refid="contribfileset" />
>     </subant>
>   </target>
> Could you please also add a line to project.classpath:
>   <path id="project.classpath">
>       <fileset dir="${additional.lib.dir}" includes="*.jar"/>
> For Debian I may not compile based on the jar files in lib but must use the 
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to