[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800982#action_12800982
]
Hadoop QA commented on ZOOKEEPER-640:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429777/ZOOKEEPER-640.patch
against trunk revision 899383.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/38/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/38/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/38/console
This message is automatically generated.
> make build.xml more configurable to ease packaging for linux distros
> --------------------------------------------------------------------
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.2.1, 3.2.2
> Reporter: Thomas Koch
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-640.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
> <project name="zookeepercontrib">
>
> <property name="contribfilesetincludes" value="*/build.xml" />
> <property name="contribfilesetexcludes" value="" />
> <fileset id="contribfileset"
> dir="."
> includes="${contribfilesetincludes}"
> excludes="${contribfilesetexcludes}"
> />
> <target name="compile">
> <subant target="jar">
> <fileset refid="contribfileset" />
> </subant>
> </target>
> Could you please also add a line to project.classpath:
> <path id="project.classpath">
> <fileset dir="${additional.lib.dir}" includes="*.jar"/>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
