-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Chris Withers wrote: > Julien Anguenot wrote: > >> The refactoring was obsious and harmless right ? Just removing hardcoded >> references to portal_catalog and portal_workflow within the internals >> of CMFCatalogAware. > > > Well, that's not refactoring is it?
I do think so. > You've added new functionality What new functionnality ? no new functionnality has been added. > with > the intent of allowing a new feature, which may, at the very best, raise > problems when multiple catalogs are in use, which, as I understand it, > is something the CMF is largely predecated against. I just removed hardcoded portal_catalog and portal_workflow references within the internals of CMFCatalogAware : this is what refactoring is about. > > For example, I've been hoping for a while to do something cleverer in > reindexObjectSecurity, but what I had in mind won't work if there's more > than one catalog where reindexObjectSecurity needs to work... Well, let's explain what you wanna do then ? It's speculation at this stage. Note, we do *not* support multiple catalogs yet. This is something we *could* support if eventually some people here are interested to discuss it. > > So I'm with Jens on this one, you could have at least done it on a > branch ;-) c'mon.. let's be serious guys... Cheers, J. - -- Julien Anguenot | Nuxeo R&D (Paris, France) CPS Platform : http://www.cps-project.org Zope3 / ECM : http://www.z3lab.org mail: anguenot at nuxeo.com; tel: +33 (0) 6 72 57 57 66 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFDJWTvGhoG8MxZ/pIRApXRAKCJz8vjmUGjgCcYVBQeTM+vPG0JpACcCPFz TV6opFwEF1da7M+Q6U3Ny3I= =m0/U -----END PGP SIGNATURE----- _______________________________________________ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests