LGTM2 % an answer to fwang@'s question On Fri, Jul 8, 2022 at 3:20 PM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM1. > > On 7/7/22 4:17 PM, Mason Freed wrote: > > Contact emails mas...@chromium.org > > Explainer https://github.com/whatwg/html/pull/7992 > > Specification https://html.spec.whatwg.org/#handler-onbeforeinput > > Summary > > The 'beforeinput' event fires when the value of an <input>, <textarea>, or > contenteditable element is about to be modified. Add an 'onbeforeinput' > global content attribute to make it easier for developers to use. > > > Blink component Blink>DOM > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> > > Search tags beforeinput > <https://chromestatus.com/features#tags:beforeinput> > > TAG review > > TAG review status Not applicable > > Risks > > > Interoperability and Compatibility > > This is shipped in both WebKit and Gecko, and the spec has landed. The > only interop risk is thus Chromium *not* shipping it. It is the addition of > a new content attribute starting with "on", so compat issues should be > negligible. > > > *Gecko*: Shipped/Shipping ( > https://bugzilla.mozilla.org/show_bug.cgi?id=970802) > > *WebKit*: Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=163021 > ) > > *Web developers*: Positive > > *Other signals*: > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > > Debuggability > > Content attributes can be seen in devtools. > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ? Yes > > Flag name > > Requires code in //chrome? False > > Tracking bug https://crbug.com/947408 > > Estimated milestones > > No milestones specified > > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > > > Link to entry on the Chrome Platform Status > https://chromestatus.com/feature/6627326972919808 > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhHadE97vZtPrAEo6dt_YJbXv3Oq%2BHMHe4eHQp7Lc_Zug%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhHadE97vZtPrAEo6dt_YJbXv3Oq%2BHMHe4eHQp7Lc_Zug%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/62382594-e621-9a51-521d-694fbbbd9a78%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/62382594-e621-9a51-521d-694fbbbd9a78%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVdV%2Bd%3DUU9%3D9vgOfah1fjv4tCeqg8zJJZXZMfZ5buQy3w%40mail.gmail.com.