LGTM3. +Daniel Vogelheim <vogelh...@chromium.org> to make sure any implications for Trusted Types and/or the Sanitizer API are taken care of.
-mike On Fri, Jul 8, 2022 at 6:28 PM Mason Freed <mas...@chromium.org> wrote: > > > On Friday, July 8, 2022 at 9:25:25 AM UTC-7 Mason Freed wrote: > >> On Thursday, July 7, 2022 at 6:58:53 PM UTC-7 fw...@igalia.com wrote: >> >>> On 07/07/2022 22:17, Mason Freed wrote: >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> H Mason, >>> >>> Do you have any patch pending to update wpt/interfaces/html.idl? >>> >> Thanks for the question. My understanding of html.idl (see the top of the >> file) is that it gets autogenerated based on landed specs. And I would have >> thought that since the spec now contains `beforeinput` in this section >> <https://html.spec.whatwg.org/#idl-definitions>, that would be enough. >> However, since that landed about a month ago, seems like not. Let me know >> if you know the proper way to kick webref <https://github.com/w3c/webref> >> to do this, and I'm happy to do it. >> > > Thanks to jarhar@ I found the answer to this question. Turns out there's > something broken on that system, so no changes have landed for just over a > month. Here's the latest PR which does include `beforeinput` > <https://github.com/web-platform-tests/wpt/pull/34155/files#diff-8a5ced105ce3ff14d97819d0e8e0921ae32e454873079f51094c6f8bbc677cf0>. > So seems like we just need a wait a bit for that to get resolved. > > >> Thanks, >> Mason >> >> >> >> >>> >>> This is used in some generic tests for global event handlers e.g. >>> >>> html/webappapis/scripting/events/event-handler-all-global-events.html >>> mathml/relations/html5-tree/math-global-event-handlers.tentative.html >>> >>> -- >>> Frédéric Wang >>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2e4dafbd-3438-464e-8874-407e0b9651d7n%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2e4dafbd-3438-464e-8874-407e0b9651d7n%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3Dcjz5f_PaYDRW0dEoSB-P0hWPWnuJff2iHR4Mp_pVrysg%40mail.gmail.com.
