Hi Andreas,
Did you already ask on the developer list for explanation etc. on what
happened (and looks unfortunate indeed). If so, what did that learn you?
If not, can you please ask the relevant questions there?
Thanks,
Cor
Andreas Mantke wrote on 05/09/2022 17:50:
As you already know I submitted on August, 26 a patch to LibreOffice
core which fixes a name change. This name change was done about five
month before and changes the naming from 'lool' to 'cool'. This name
change breaked the connection from the LibreOffice Online repository and
its downstream consumers. It also changed the naming from a vendor
neutral to the naming of a commercial OSS company.
The patch was tested by Jenkins without any issues. Then a developer
with review permissions gave a +2 and marked the patch ready for
integration.
Because nobody with ther permission to merge the patch took care of the
patch and submitted it to the core repo I asked about the procedure with
volunteer patches some days later here (and on the developer list too).
I got the message then that the commit message is not okay, because it
didn't reflect the code change. I amended the commit message as requested.
Then after some more comments on Gerrit one developer edited my patch.
This patch reverted my changes and added totally different lines of code
to the patch set. The commit message wasn't changed. This totally new
patch set was reviewed by the author of the new patch set, marked ready
for integration and merged.
This developer didn't asked me, if I'm fine with the new patch.
Nevertheless the merged patch is marked as signed by me. The new patch
didn't revert the naming change, done about five month ago. The changed
naming to 'cool' stayed in the LibreOffice core repository and it is not
yet clear, if and when this line will be removed ever.
In addition the new patch breaks the connection to two downstream
consumer projects and to the LibreOffice online repository too.
This new patch was merged as signed by me. I wasn't asked if I was fine
with the new patch and I never signed this new patch (and are not fine
with it).
I see this as a violation and ask TDF to de-merge the patch.
In addition: in my opinion there is much space for improving the
interaction with volunteer developers inside the LibreOffice community.
But maybe this only my opinion and everyone else is fine with the
current process.
Regards,
Andreas
--
## Free Software Advocate
## Plone add-on developer
## My blog: http://www.amantke.de/blog
--
Cor Nouws, member Board of Directors
The Document Foundation, Kurfürstendamm 188, 10707 Berlin
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28 A038 E49D 7365 B134 80A6
mobile : +31 (0)6 25 20 7001
skype : cornouws
blog : cor4office-nl.blogspot.com
jabber : cor4off...@jabber.org
--
To unsubscribe e-mail to: board-discuss+unsubscr...@documentfoundation.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.documentfoundation.org/www/board-discuss/
Privacy Policy: https://www.documentfoundation.org/privacy
