On Wed, 2008-08-27 at 01:20 +0300, Sjur Moshagen wrote: > Den 26. aug. 2008 kl. 12.49 skrev Thorsten Scherler: > > >> I need to review your commit. > > ... > > > > I had a quick look on the weekend but I am not sure. Many featured you > > described in this thread seems to be not commited yet. Is that > > correct, > > because you wrote that you have some stack of changes on your local > > box. > > Yes, I do. Right now I'm travelling, and don't have time for any > commits. > > But the basic issue is that I don't want to commit, because I know I > would break PDF functionality in dispatcher - but I won't get any > feedback if I don't commit. A separate branch could be overkill, and > dispatcher is in the whiteboard... Would broken PDF functionality for > dispatcher be ok through a short period of time? (some days or so)? >
If is not possible to do the commit without breaking the dispatcher it seems acceptable. However we need to make sure that we disable the forrestbot on zones for the dispatcher site meanwhile otherwise we will get again a flood of build fail messages. salu2 > Best regards, > Sjur > -- Thorsten Scherler thorsten.at.apache.org Open Source Java consulting, training and solutions
