Can someone with a Mac test this patch and see if it works for IE and/or
Mozilla, Safari, etc? Again what is being tested it the use of the
Command key for selecting single non-continuous messages.
-Charles
Charles McNulty wrote:
Actually, looking at the code again, it might not be that hard to
support IE for Mac. Can any Mac users confirm on this page:
http://www.quirksmode.org/js/events/keys.html
that the keyCode for Command is 91?
-Charles
Jamie Halmick wrote:
The standard behavior is for
command-click to perform non-contiguous multiple select.
shift-click performs contiguous multiple select
command-shift-click appears to perform just like shift-click
At least that's how it works in the Finder, which I think should be
the Mac
reference for this type of behaviour.
I think that substituting command for control with the current roundcube
behaviour would be fine though as it's really just "more" functionality.
: jamie
--------
"Much human ingenuity has gone into finding the ultimate Before. The
current
state of knowledge can be summarized thus: In the beginning, there was
nothing,
which exploded"
- Terry Pratchett
On Thu, 02 Mar 2006 16:21:20 -0600, Charles McNulty
<[EMAIL PROTECTED]> wrote:
Is that the standard behavior for Macs? When I implemented the
select/control-click behavior, I studied exactly what Outlook, Outlook
Express and Thunderbird did in Windows (XP) and attempted to emulate
that exact behavior. I don't have a Mac, but if someone could describe
the exact behavior and key combinations with a Mac on a similar set of
standard applications, I'd be happy to attempt to implement it.
Key combinations to test are:
Click
Shift-Click
Command-Click
Command-Shift-Click
Situations to test are each of these in different combinations with each
other in different scenarios:
When nothing is selected
When a continous list of things are selected
When a non-continuous list of things are selected
So for instance, what happens when you click a list item, shift-click an
item 5 below it, command-click an item two up from that one and then
command-shift-click an item another 10 up from that?
If you can tell me definitively that a Command-click and
command-shift-click do the exact same thing in all situations as a
Control, then that will be an easy change. The key is predictability.
What I'm going for here is the exact same behavior in RC as in ... well
whatever you Mac users use for e-mail.
-Charles
Jamie Halmick wrote:
This new select behavior is nice for contiguous selection but doesn't
really work on Macintosh. When you control-click you get the context
menu
(right click for Mac). Can you add the behavior so that the Command key
will do the same on the Mac as Control?
: jamie
--------
"I love deadlines. I like the whooshing sound they make as they fly by"
- Douglas Adams
Index: app.js
===================================================================
RCS file: /cvsroot/roundcubemail/roundcubemail/program/js/app.js,v
retrieving revision 1.32
diff -r1.32 app.js
268d267
< if (e.stopPropagation) e.stopPropagation();
296c295
< } else {return false};
---
> } else {return true;}
2967a2967,2972
> var keyControl = e.ctrlKey
>
> if (this.mac) {
> keyControl = (e.keyCode = 91)
> }
>
2970c2975
< opcode += (e.ctrlKey && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY);
---
> opcode += (keyControl && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY);
