Hi,

Am 24.09.2010 13:06, schrieb Ian Boston:
> 
> On 24 Sep 2010, at 11:57, Felix Meschberger wrote:
> 
>> Hi,
>>
>> Am 24.09.2010 12:39, schrieb Ian Boston:
>>>
>>> On 24 Sep 2010, at 11:21, Carsten Ziegeler wrote:
>>>
>>>> Ian Boston  wrote
>>>>>
>>>>> On 24 Sep 2010, at 11:06, Carsten Ziegeler wrote:
>>>>>
>>>>>> So if you
>>>>>> want to update this content, you should update the corresponding bundle.
>>>>>
>>>>> Thats the bit thats not really working (unless I say overwrite:=true)
>>>> Yes, right - that's why you should have overwrite:=true :)
>>>>
>>>>
>>>>> as Felix said, perhaps the default should be the content gets updated if 
>>>>> the bundle gets updated, although thats going to break for anyone who was 
>>>>> expecting edits post bundle load to remain.
>>>>
>>>> Yepp, right, I think this would make more sense for the a default.
>>>
>>> There is one problem with using the lastModified timestamp per content 
>>> file, it comes from the URL, which comes from the Jar, and since that comes 
>>> from the temporary file where the jar is being installed from it may not 
>>> represent the last modified time of the bundle. In the case of a bundle 
>>> that has been posted over http, that is certainly the case. Not so certain 
>>> about a bundle that was installed via bootstrap.
>>
>> That's not entirely true, actually.
>>
>> IIRC the timestamp in fact comes from the URL but it comes either from
>> the actual file inside the bundle JAR or it comes from the providing
>> bundle's last modification time (Bundle.getLastModified()).
> 
> Ahh,
> Ok, although that is the time when the bundle was installed or updated, not 
> when it was last bundled.

Yes.

> Bnd-LastModfied looks like it gets updated when bundled (provided the Bnd 
> Tool is used)

Yes, well for most bundles, this is probably usable nowadays ;-)

> 
> Use that, and fall back to Bundle.getLastModified() is missing?

The correct thing is to use URLConnection.getLastModified(), which
unfortunately gives you the Bundle.getLastModified() in Felix but may at
the same time give you the correct answer ...

How about this: Get both (if available) and assume the older (smaller
number) ?

Regards
Felix

> Ian
> 
> 
> 
>>
>> Regards
>> Felix
>>
>>>
>>> Is this going to be Ok ?
>>> Ian
>>>
>>>
>>>
>>>>
>>>> Carsten
>>>> -- 
>>>> Carsten Ziegeler
>>>> cziege...@apache.org
>>>
>>>
> 
> 

Reply via email to