bambadiouf1 commented on code in PR #37377:
URL: https://github.com/apache/beam/pull/37377#discussion_r3150343163
##########
sdks/python/apache_beam/runners/dataflow/internal/clients/dataflow/dataflow_v1b3_messages.py:
##########
@@ -8047,11 +8062,3 @@ class WriteInstruction(_messages.Message):
StandardQueryParameters.FXgafvValueValuesEnum, '_1', '1')
encoding.AddCustomJsonEnumMapping(
StandardQueryParameters.FXgafvValueValuesEnum, '_2', '2')
-encoding.AddCustomJsonFieldMapping(
- DataflowProjectsLocationsTemplatesLaunchRequest,
'dynamicTemplate_gcsPath', 'dynamicTemplate.gcsPath')
-encoding.AddCustomJsonFieldMapping(
- DataflowProjectsLocationsTemplatesLaunchRequest,
'dynamicTemplate_stagingLocation', 'dynamicTemplate.stagingLocation')
-encoding.AddCustomJsonFieldMapping(
- DataflowProjectsTemplatesLaunchRequest, 'dynamicTemplate_gcsPath',
'dynamicTemplate.gcsPath')
-encoding.AddCustomJsonFieldMapping(
- DataflowProjectsTemplatesLaunchRequest, 'dynamicTemplate_stagingLocation',
'dynamicTemplate.stagingLocation')
Review Comment:
Thanks a lot, Danny! I did a pull origin but the regenerating the gen_client
causes these lines to be deleted for some reasons, so I reverted the changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
