damccorm commented on PR #37377: URL: https://github.com/apache/beam/pull/37377#issuecomment-4344967465
> Hey, this PR actually breaks the Dataflow protos in python by changing field numbers for existing fields. Additionally, this is changing the internally generated python client that we're in the process of deprecating. I'd suggest reverting this PR and removing the Python-specific code This is my fault, I should've caught the conflict. The relevant PR making this change is https://github.com/apache/beam/pull/37639, which would basically need to undo all the Python pieces here. I agree, lets: 1) Revert 2) Put up another PR with just the Java and Go side changes. We can merge that immediately. 3) Address the Python pieces separately. @jrmccluskey could you help Bamba with that after you merge your PR? (either by just doing it or providing code pointers on what changes need to happen) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
