gemini-code-assist[bot] commented on code in PR #37377:
URL: https://github.com/apache/beam/pull/37377#discussion_r3154741469


##########
CHANGES.md:
##########
@@ -68,6 +68,7 @@
 
 ## New Features / Improvements
 
+* Added support for setting disk provisioned IOPS and throughput in Dataflow 
runner via `--diskProvisionedIops` and `--diskProvisionedThroughputMibps` 
pipeline options (Java/Python/Go) 
([#37377](https://github.com/apache/beam/issues/37377)).

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The flag names listed here (`--diskProvisionedIops` and 
`--diskProvisionedThroughputMibps`) are only accurate for the Java SDK. In 
Python and Go, these pipeline options use snake_case: `--disk_provisioned_iops` 
and `--disk_provisioned_throughput_mibps`. Please update the description to be 
accurate for all supported languages.
   
   ```suggestion
   * Added support for setting disk provisioned IOPS and throughput in Dataflow 
runner (Java/Python/Go) ([#37377](https://github.com/apache/beam/issues/37377)).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to