On Mon, Jul 11, 2011 at 23:23, Ferenc Kovacs <tyr...@gmail.com> wrote: > On Mon, Jul 11, 2011 at 11:09 PM, Hannes Magnusson > <hannes.magnus...@gmail.com> wrote: >> On Mon, Jul 11, 2011 at 22:13, Ferenc Kovacs <tyr...@gmail.com> wrote: >>>> Stas means when we print who has voted, to only print votes by people >>>> in that group so you won't need to manually filter out >>>> not-allowed-to-vote votes. >>>> >>>> -Hannes >>>> >>> >>> I see. >>> if you only need the @php.net usernames, you can use the >>> https://master.php.net/fetch/allusers.php api with the proper token, >>> or https://bugs.php.net/js/userlisting.php without it. >> >> Or just ask the internal wiki api if the username is in the phpcvs/voted >> group. >> No need to make it complicated. > > oh, I didn't though of that, as this is how my patch works (albeit > only for the new votes, but still). :) > >> >> The whole idea of this sort of workaround is however very silly to me. > > thanks for sharing, this kind of comments which keeps me contributing ;)
I don't think you are understanding the point here. There are currently bucketloads of registered votes for the php54 feature list which "should not be there". The idea Stas proposed of leaving the votes untouched and just hide those specific votes during rendering of the vote results is very silly to me. Manually summerizing the votes like has been done in the past on many RFCs into "with karma" and "without" results would make much more sense to me, especially since there are so many registered votes already. It was in no remotely close way anything at all related to the patch you wrote and was committed earlier. -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
