Hi Julien, hi all, > Michael Prokop <m...@grml.org> wrote: > > Hi, > > > If Michael Tautschnig as setup-storage maintainer acknowledges the > > patch and either you or MT applies it to svn so I can cherry-pick it > > from there that's absolutely fine for me and I'd provide it as 3.4.3 > > release, sure. > > OK, let's wait for Michael's review :) >
OMG, sorry for being that slow; I've been too busy with real life. Well, here it
is: First of all, thanks Julien for debugging this and providing a carefully
crafted patch!!! I had only noticed that always_format issue just minutes ago
(and one of the recent patches in experimental also fixes it, but it's
absolutely fine if the fix goes in via this patch). Just one stylistic note:
Unless I'm missing something, the following if ... elsif ...
> - if (&FAI::set_partition_type_on_phys_dev($d, "raid")) {
> + if ($vol->{preserve}) {
> + $pre_req .= ",pt_complete_" . (&FAI::phys_dev($d))[1];
> + } elsif (&FAI::set_partition_type_on_phys_dev($d, "raid")) {
> $pre_req .= ",pt_complete_" . (&FAI::phys_dev($d))[1];
> } else {
> $pre_req .= ",exist_$d";
> }
> }
... could be rewritten as
if ($vol->{preserve} || &FAI::set_partition_type_on_phys_dev($d, "raid"))
Other than this, I'm completely fine with the patch and I'd suggest Julien
merges it into trunk himself. Julien, please also add a changelog entry *in a
separate commit*. I'll take care of updating my patches in experimental
afterwards.
[...] (RC bug discussion, Mika and you had resolved that already nicely anyhow.)
Thanks again,
Michael
pgpincvyQaDuF.pgp
Description: PGP signature
