On Fri, 21 Apr 2017 12:34:00 +0200, Jose Abreu wrote: > > Hi, > > > On 20-04-2017 21:24, Takashi Iwai wrote: > > So, I think Lubomir's change is right. But the patch subject and > > description should be rephrased. > > > > One thing I don't like is the rename of the file. But in this > > particular case, it's unavoidable unless we rename the module name. > > > > Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is > called "dwc") and let the module still be called "designware-i2s"?
Lubomir's patch keeps the module name intact. My point is that rename of a file isn't nice to look at the git commit history, so it's better to be avoided as much as possible. But in this case, it looks unavoidable. Takashi
