> Hmmm, allocs -> callocs. Are these actually beneficial? If so, why? > Because one multiplication is rolled into the call?
Did the previous size calculations contain the general possibility for integer overflows? https://cwe.mitre.org/data/definitions/190.html * Will the computed values usually stay within the limits of the used data types so far? * How much do you care for corresponding checks and source code annotations by functions like “devm_kcalloc”? Regards, Markus