>-----Original Message----- >From: Zhenyu Wang [mailto:zhen...@linux.intel.com] >Sent: Wednesday, May 31, 2017 2:30 PM >To: Chen, Xiaoguang <xiaoguang.c...@intel.com> >Cc: Tian, Kevin <kevin.t...@intel.com>; intel-...@lists.freedesktop.org; linux- >ker...@vger.kernel.org; ch...@chris-wilson.co.uk; alex.william...@redhat.com; >kra...@redhat.com; Niu, Bing <bing....@intel.com>; intel-gvt- >d...@lists.freedesktop.org; Wang, Zhi A <zhi.a.w...@intel.com>; Lv, Zhiyuan ><zhiyuan...@intel.com> >Subject: Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g > >On 2017.05.31 06:22:28 +0000, Chen, Xiaoguang wrote: >> >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject >> >> *kobj, >> >struct mdev_device *mdev) >> >> vgpu->vdev.mdev = mdev; >> >> mdev_set_drvdata(mdev, vgpu); >> >> >> >> + ret = intel_vgpu_reg_init_opregion(vgpu); >> >> + if (ret) { >> >> + gvt_vgpu_err("create OpRegion failed\n"); >> >> + goto out; >> >> + } >> > >> >Still need to handle error path for created vgpu. >> Just checked the code, if initialize the opregion failed we should first >> release >vfio/mdev releated work(maybe call intel_vgpu_release function) and then >destroy the vgpu. Will update in the next version. >> > >Better to init opregion inside of create vgpu and do proper error handling >there >too. Then we must add a new entry in intel_gvt_mpt interface something like "create_opregion".
> >-- >Open Source Technology Center, Intel ltd. > >$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
